Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Run unit tests on Python 3.13 #622

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 23, 2024

@cclauss cclauss changed the title GitHub Actions: Run unit test on Python 3.13 GitHub Actions: Run unit tests on Python 3.13 Oct 23, 2024
Copy link

github-actions bot commented Oct 23, 2024

Binder 👈 Launch a binder notebook on this branch for commit 8178369

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 6e19470

Binder 👈 Launch a binder notebook on this branch for commit 2264106

Binder 👈 Launch a binder notebook on this branch for commit 9432621

Binder 👈 Launch a binder notebook on this branch for commit 07afaea

Binder 👈 Launch a binder notebook on this branch for commit 2cfaf33

Binder 👈 Launch a binder notebook on this branch for commit b404fe5

Binder 👈 Launch a binder notebook on this branch for commit c1688d3

Binder 👈 Launch a binder notebook on this branch for commit c738322

Binder 👈 Launch a binder notebook on this branch for commit d534af0

Binder 👈 Launch a binder notebook on this branch for commit dc475de

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.90%. Comparing base (54e3c1d) to head (dc475de).
Report is 1 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #622      +/-   ##
===============================================
- Coverage        71.88%   66.90%   -4.98%     
===============================================
  Files               37       35       -2     
  Lines             3112     3058      -54     
  Branches           422      422              
===============================================
- Hits              2237     2046     -191     
- Misses             764      925     +161     
+ Partials           111       87      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cclauss cclauss marked this pull request as draft October 23, 2024 16:59
@weiji14
Copy link
Member

weiji14 commented Oct 23, 2024

Waiting on numba/numba#9413, which in turn is waiting on llvmlite upstream.

Collecting numba (from datashader->icepyx==1.3.1.dev10+g16b2ffd)
  Downloading numba-0.60.0.tar.gz (2.7 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.7/2.7 MB 28.2 MB/s eta 0:00:00
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [24 lines of output]
      Traceback (most recent call last):
        File "/opt/hostedtoolcache/Python/3.13.0/x64/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
          ~~~~^^
        File "/opt/hostedtoolcache/Python/3.13.0/x64/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ~~~~^^^^^^^^^^^^^^^^^^^^^^^^
        File "/opt/hostedtoolcache/Python/3.13.0/x64/lib/python3.13/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
        File "/tmp/pip-build-env-w55jox8j/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 332, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
                 ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-w55jox8j/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 302, in _get_build_requires
          self.run_setup()
          ~~~~~~~~~~~~~~^^
        File "/tmp/pip-build-env-w55jox8j/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 516, in run_setup
          super().run_setup(setup_script=setup_script)
          ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-w55jox8j/overlay/lib/python3.13/site-packages/setuptools/build_meta.py", line 318, in run_setup
          exec(code, locals())
          ~~~~^^^^^^^^^^^^^^^^
        File "<string>", line 51, in <module>
        File "<string>", line 48, in _guard_py_ver
      RuntimeError: Cannot install on Python version 3.13.0; only versions >=3.9,<3.13 are supported.
      [end of output]

@cclauss
Copy link
Contributor Author

cclauss commented Jan 9, 2025

Blocked waiting for numba>=0.61.0... Tests pass on release candidate 2.

requirements.txt: numba==0.61.0rc2; python_version == '3.13' # FIX ME!!!

@JessicaS11
Copy link
Member

@cclauss Should we go ahead and merge with your fix, or would it be better to wait for numba>=0.61.0?

@cclauss
Copy link
Contributor Author

cclauss commented Jan 9, 2025

We can wait... We should not use a dependency's pre-release version in production.

@cclauss
Copy link
Contributor Author

cclauss commented Jan 21, 2025

numba v0.61.0 has been released... https://pypi.org/project/numba/0.61.0/#history

@cclauss
Copy link
Contributor Author

cclauss commented Jan 21, 2025

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datashader 0.17.0 came out, so Python 3.13 tests are passing now 🎉

@cclauss cclauss marked this pull request as ready for review February 12, 2025 20:17
@cclauss
Copy link
Contributor Author

cclauss commented Feb 12, 2025

@JessicaS11 I think we are ready when you are. 🚀

@JessicaS11 JessicaS11 merged commit 9591d12 into icesat2py:development Feb 20, 2025
8 of 9 checks passed
@cclauss cclauss deleted the patch-1 branch February 20, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants